[wgsl] Add runtime-sized array validation rules #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
reviewed
Nov 24, 2020
sarahM0
force-pushed
the
runtime-block
branch
2 times, most recently
from
ad2a2b0 to
b66060f
Compare
Contributor
Author
|
I just added v-0032. Thanks to @kainino0x and @Kangz for bringing it up. |
Contributor
Author
|
Thanks for the feedback @kvark. I rewrote the rules to avoid redundancies. |
kvark
approved these changes
Nov 30, 2020
dj2
approved these changes
Nov 30, 2020
sarahM0
force-pushed
the
runtime-block
branch
from
9de39cd to
62a0bee
Compare
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
This CL adds unimplemented stub tests for the `dpdy` builtin. Issue: gpuweb#1252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are my proposed validation rules for runtime-sized arrays:
v-0015: The last member of the structure type defining the "store type" for variable in the storage storage class may be a runtime-sized array.
v-0030: A runtime-sized array must not be used as the store type or contained within a store type except as allowed by v-0015
v-0031: The type of an expression must not be a runtime-sized array type.
v-0032: A runtime-sized array must have a stride attribute.