Add markdown (and mathjax) support in leaderboard descriptions#98
Open
skimberk wants to merge 1 commit intogpu-mode:mainfrom
Open
Add markdown (and mathjax) support in leaderboard descriptions#98skimberk wants to merge 1 commit intogpu-mode:mainfrom
skimberk wants to merge 1 commit intogpu-mode:mainfrom
Conversation
…ews and leaderboard markdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #38 this adds Markdown support in leaderboard descriptions. With the v2 frontend, this looks a bit different than the attempt in #39. It also looks like the v2 frontend lost support for mathjax in the descriptions (although I'm not sure if it's actually used anywhere?) so this adds it back, as well as adds mathjax support to the news page (since they both now use the same
MarkdownRenderercomponent.Mostly followed instructions here for getting mathjax working with
react-markdown: https://github.com/remarkjs/react-markdown#use-remark-and-rehype-plugins-mathOne issue:
Ran tests locally:
Also tried adding some markdown and math to a description to test how it renders (see

$$E=mc^2$$at the bottom):I actually wrote this one by hand, as I can't say my trust in CoPilot is especially high after dealing with it in #97, I feel like I spent a long time just trying to figure out what the hell it was doing.
@b9r5 @msaroufim