Implement polling for internal devices#941
Merged
Merged
Conversation
bennuttall
reviewed
Mar 13, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
I've added an intro to the internal devices docs page, added I've also switched some source/values examples to when_activated/deactivated. A couple of thoughts:
|
bennuttall
force-pushed
the
sample-internal
branch
from
b3f5f65 to
6a783b8
Compare
Member
|
Is |
And clean up event handling generally. All the logic to do with wrapping callbacks, and ensuring watch threads is set up should be handled by the EventsMixin or other helper classes (in this case a property analogue called "event"). Fixes #393
bennuttall
force-pushed
the
sample-internal
branch
from
6a783b8 to
66a0e5f
Compare
Member
Author
It should be implicitly by |
waveform80
commented
Mar 14, 2021
waveform80
commented
Mar 14, 2021
In my zeal for efficiency the background thread wasn't running when only the wait-for methods were called!
bennuttall
approved these changes
Mar 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And clean up event handling generally. All the logic to do with wrapping callbacks, and ensuring watch threads is set up should be handled by the EventsMixin or other helper classes (in this case a property analogue called "event").
Fixes #393