-
Notifications
You must be signed in to change notification settings - Fork 570
Example of regenerated minified files #765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
afc154c to
c56bd43
Compare
|
Thanks for prototyping this @myitcv. This approach looks pretty much as I expected. 👍 I like the idea of using I still prefer not to automate this just yet, because the prelude doesn't change often and it's not much harder to do it as done in #761. Should that change, we can reopen this PR and resume here. Thanks. |
Use uglify-es 3.3.9 via https://skalman.github.io/UglifyJS-online/ with default options. Currently, it needs to be manually updated whenever prelude changes. It's not very often. When that changes, it can be automated via #765. Resolves #762. Closes #761. Co-authored-by: Dmitri Shuralyov <dmitri@shuralyov.com>
As I understand things going the extra step to automate this (especially given the prototype confirms it's straightforward) is worthwhile because:
Unless I'm missing something in the way the alternative works? |
|
I think it's worthwhile if the prelude changes often. Historically, it has changed very little (a few times in the last few years), although the frequency might be increasing recently. I think it's fair to wait until it changes 2-3 more times before going through with automating it. To me, that's easier. |
I'm not entirely sure I follow, particularly given the experience of #775 (specifically #775 (comment)) Because the work to automate it is already done; that's what this PR represents. Or am I missing something? Can I suggest I rebase this PR, ensure CI works and then we see what the diff looks like? |
This is a rebase of #765. Whilst rebasing #669 I fell into a similar trap to #775 (#775 (comment)), by forgetting to commit the manually minified prelude. Then going through the manual process of manually minifying the prelude I wasted a whole load of time installing goexec, missing something the first time etc, issues that this PR addresses by automating the process, as previously discussed (#765 (comment)).
DO NOT MERGE
Example of auto-regenerated prelude files; potential follow-up to #761