identity: add RegionID to endpoints - #4000
Open
Sharpz7 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
edit:identity
|
coverage: 63.519%. remained the same — Sharpz7:codex/issue-3943-region-id into gophercloud:main |
winiciusallan
left a comment
winiciusallan
left a comment
Contributor
There was a problem hiding this comment.
Very straightforward, thanks! Would you mind adding it to the acceptance tests as well?
mandre
reviewed
Sep 3, 2026
| @@ -58,6 +58,9 @@ type Endpoint struct { | |||
| // Region is the region the Endpoint is located in. | |||
Contributor
There was a problem hiding this comment.
Perhaps note that this field is deprecated in favor of RegionID in v3.2?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the missing
region_idfield to Identity v3 endpoint responses and covers it in the existing list test.Fixes #3943
Tested:
go test ./openstack/identity/v3/endpoints/...Assisted by Codex