Return early on initClientOpts error in service client constructors - #3989
Merged
Conversation
github-actions
Bot
added
the
edit:openstack
github-actions
Bot
added
semver:patch
|
coverage: 63.556% (-0.02%) from 63.58% — shiftstack:clean-client-init into gophercloud:main |
kayrus
approved these changes
Aug 28, 2026
barnes-c
added a commit
to barnes-c/gophercloud
that referenced
this pull request
Aug 28, 2026
winiciusallan
approved these changes
Aug 28, 2026
winiciusallan
left a comment
winiciusallan
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix! Waiting for green jobs before merging; the failure looks unrelated with the changes
Several New* functions access the ServiceClient returned by initClientOpts without checking the error first. On error paths, this results in setting fields like ResourceBase on a half-initialized client (e.g. ResourceBase = "v2.0/"). Add early error returns to avoid modifying a client that failed to initialize.
mandre
force-pushed
the
clean-client-init
branch
from
August 28, 2026 19:59
a819b4f to
d723813
Compare
|
Failed to backport PR to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several New* functions access the
ServiceClientreturned byinitClientOptswithout checking the error first. On error paths, this results in setting fields likeResourceBaseon a half-initialized client (e.g.ResourceBase = "v2.0/"). Add early error returns to avoid modifying a client that failed to initialize.