Skip to content

fix(config/clouds): resolve reference to clouds-public.yaml - #3949

Merged
stephenfin merged 1 commit into
gophercloud:mainfrom
AntoninRuan:cloud_parsing
Aug 21, 2026
Merged

fix(config/clouds): resolve reference to clouds-public.yaml#3949
stephenfin merged 1 commit into
gophercloud:mainfrom
AntoninRuan:cloud_parsing

Conversation

@AntoninRuan

Copy link
Copy Markdown
Contributor

Fixes #3948

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://docs.openstack.org/python-openstackclient/2026.1/configuration/index.html#clouds-public-yaml

@github-actions github-actions Bot added the edit:config This PR updates config code label Aug 15, 2026
Comment thread openstack/config/clouds/clouds.go Outdated
Comment thread openstack/config/clouds/clouds.go Outdated
Comment thread openstack/config/clouds/clouds.go Outdated
Comment thread openstack/config/clouds/clouds.go Outdated
Comment thread openstack/config/clouds/clouds.go Outdated
Comment thread openstack/config/clouds/options.go
Comment thread openstack/config/clouds/clouds.go
Comment thread openstack/config/clouds/types.go
@AntoninRuan

Copy link
Copy Markdown
Contributor Author

And a more overall question that I don't remenber seeing addresses in the contributing guideline, what is the preffered way to edit a PR: amending the commit to keep only one commit in the PR, or adding new commit for each round of corrections?

@stephenfin

Copy link
Copy Markdown
Contributor

And a more overall question that I don't remenber seeing addresses in the contributing guideline, what is the preffered way to edit a PR: amending the commit to keep only one commit in the PR, or adding new commit for each round of corrections?

We don't have one. I'd typically prefer amending commits and force pushing, but GitHub's UI works better with follow-up commits. Do whatever you're used to/prefer.

@github-actions github-actions Bot added semver:minor Backwards-compatible change backport-v2 This PR will be backported to v2 labels Aug 19, 2026
@coveralls

coveralls commented Aug 19, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 63.58% (+0.007%) from 63.573% — AntoninRuan:cloud_parsing into gophercloud:main

@AntoninRuan

Copy link
Copy Markdown
Contributor Author

@stephenfin I've just added in a different commit my attempt at loading every file independently of each others. I am not fully satisfied notably the way I handled errors I think it could be better. (maybe it would be a good idea to separate the commit in a different pr, I'll let you decide what you think is best).
I think I've also fixed almost all comments in an amend of the first commit, expect the warning one as I did not know how you wanted to handle warning emmision

@stephenfin

Copy link
Copy Markdown
Contributor

@stephenfin I've just added in a different commit my attempt at loading every file independently of each others. I am not fully satisfied notably the way I handled errors I think it could be better. (maybe it would be a good idea to separate the commit in a different pr, I'll let you decide what you think is best). I think I've also fixed almost all comments in an amend of the first commit, expect the warning one as I did not know how you wanted to handle warning emmision

Yes, could you keep this locally but drag it out of this PR (or consider creating one of the newfangled stacked PRs?) I'll hold off reviewing until that's done to avoid losing review comments.

@AntoninRuan

Copy link
Copy Markdown
Contributor Author

Ok I'll do that

@AntoninRuan

Copy link
Copy Markdown
Contributor Author

Done. I did not find a way to create stacked PRs as both branch are on my fork rather than this repo. I'll just keep the branch and open a new later on

stephenfin
stephenfin previously approved these changes Aug 20, 2026

@stephenfin stephenfin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that we have test helpers to simplify much of the error checking in tests. If you have time to fix, I'm happy to re-review.

Comment thread openstack/config/clouds/clouds_test.go Outdated
Comment thread openstack/config/clouds/clouds_test.go Outdated
@stephenfin
stephenfin enabled auto-merge August 21, 2026 11:20
@stephenfin
stephenfin added this pull request to the merge queue Aug 21, 2026
Merged via the queue into gophercloud:main with commit 95eea8e Aug 21, 2026
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:config This PR updates config code semver:minor Backwards-compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clouds.Parse does not read clouds-public.yaml

3 participants