fix(config/clouds): resolve reference to clouds-public.yaml - #3949
Conversation
334dbac to
0685fbc
Compare
|
And a more overall question that I don't remenber seeing addresses in the contributing guideline, what is the preffered way to edit a PR: amending the commit to keep only one commit in the PR, or adding new commit for each round of corrections? |
We don't have one. I'd typically prefer amending commits and force pushing, but GitHub's UI works better with follow-up commits. Do whatever you're used to/prefer. |
0685fbc to
53955cd
Compare
|
@stephenfin I've just added in a different commit my attempt at loading every file independently of each others. I am not fully satisfied notably the way I handled errors I think it could be better. (maybe it would be a good idea to separate the commit in a different pr, I'll let you decide what you think is best). |
Yes, could you keep this locally but drag it out of this PR (or consider creating one of the newfangled stacked PRs?) I'll hold off reviewing until that's done to avoid losing review comments. |
|
Ok I'll do that |
2906f71 to
53955cd
Compare
|
Done. I did not find a way to create stacked PRs as both branch are on my fork rather than this repo. I'll just keep the branch and open a new later on |
stephenfin
left a comment
There was a problem hiding this comment.
Just noting that we have test helpers to simplify much of the error checking in tests. If you have time to fix, I'm happy to re-review.
53955cd to
bbff4e2
Compare
Fixes #3948
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://docs.openstack.org/python-openstackclient/2026.1/configuration/index.html#clouds-public-yaml