feat: support for updating and deleting share access rule metadata - #3921
Open
simonostendorf wants to merge 3 commits into
Open
feat: support for updating and deleting share access rule metadata#3921simonostendorf wants to merge 3 commits into
simonostendorf wants to merge 3 commits into
Conversation
simonostendorf
commented
Aug 7, 2026
simonostendorf
commented
- Implement UpdateMetadata and DeleteMetadatum functions in shareaccessrules.
- Add corresponding test cases for metadata update and deletion.
- Enhance GrantAccess to include metadata options.
- Update related request and result structures to handle metadata.
- Implement UpdateMetadata and DeleteMetadatum functions in shareaccessrules. - Add corresponding test cases for metadata update and deletion. - Enhance GrantAccess to include metadata options. - Update related request and result structures to handle metadata.
github-actions
Bot
added
the
edit:sharedfilesystems
winiciusallan
left a comment
winiciusallan
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall. I'd like to see how tests goes.
Author
@winiciusallan thanks! Currently the tests are waiting for approval |
|
coverage: 63.574% (+0.04%) from 63.534% — simonostendorf:feat/sharedfilesystems-shareaccessrule-metadata into gophercloud:main |
Sharpz7
reviewed
Sep 2, 2026
Author
|
One question: Why is the pr marked as major version, I thought ive only added a new feature so it should be minor, right? |
Contributor
Per the job logs Code relying on deeply comparing the struct might have breaking changes because of the new fields. |
mandre
reviewed
Sep 3, 2026
… share access rules
winiciusallan
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.