Use slices for tag qs filters - #3918
Conversation
github-actions
Bot
added
edit:networking
|
coverage: 63.582%. remained the same — shiftstack:tags-qs-slice into gophercloud:main |
IlanZuckerman
left a comment
IlanZuckerman
left a comment
There was a problem hiding this comment.
I would add a few UT's that would prove the query string is built correctly.
For example assert that list opts turn into ?tags=a,b (not ?tags=a&tags=b).
a2ca650 to
d68bf13
Compare
|
The networking failures are unrelated. #3945 will address them. |
|
Now we have #3945 merged, I believe we can re-run the jobs. @stephenfin Would you mind triggering them? |
This is more intuitive. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change ListOpts.RevisionNumber to a *int. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
d68bf13 to
17c2b3a
Compare
I've rebased and forced pushed |
winiciusallan
left a comment
winiciusallan
left a comment
There was a problem hiding this comment.
I found another set of fields that could be potentially changed to use a slice, see
while we're here and if it makes sense, i believe it's worth changing.
There was a problem hiding this comment.
Can we also exercise this changes on servers in the acceptance tests?
4 participants
This was already done for the loadbalancer service. Do it for other services.
This is a breaking change that should not be backported to v2. While here, we also fix a TODO with another filter.