Don't require to shell-escape conf_overrides #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use heredoc syntax to append the value of `conf_overrides` to the `local.conf` file. Compared to the previous solution using `echo`, this removes the need to shell escape your value. Also remove the useless test, since the default value for `inputs.conf_overrides` is an empty string which results in a noop. Fixes gophercloud#19.
Member
|
LGTM 👍 |
Contributor
|
Merged from the beach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use heredoc syntax to append the value of
conf_overridesto thelocal.conffile. Compared to the previous solution usingecho, this removes the need to shell escape your value.Also remove the useless test, since the default value for
inputs.conf_overridesis an empty string which results in a noop.Fixes #19.