Skip to content

Add requirements.txt to all quickstarts#84

Merged
sqrrrl merged 1 commit intomasterfrom
requirements.txt
Feb 26, 2019
Merged

Add requirements.txt to all quickstarts#84
sqrrrl merged 1 commit intomasterfrom
requirements.txt

Conversation

@grant
Copy link
Copy Markdown
Contributor

@grant grant commented Feb 26, 2019

Fixes #2.

  • Adds the standard requirements.txt file to each quickstart directory.
    • Rather than "pip install ", we are using the standard "pip install -r".
    • This change is independent of DevSite instructions.

This ensures the compatibility of the dependencies so that we don't see a quickstart randomly break.

Tested locally.

Ideally the user has venv set up, but we've never enforced that or added that to the quickstart docs.

This requirements.txt setup is similar to what we can see in the GCP python repo.

@erickoledadevrel erickoledadevrel requested review from sqrrrl and removed request for erickoledadevrel February 26, 2019 14:27
@erickoledadevrel
Copy link
Copy Markdown

Assigning to @sqrrrl, since he is on-call this week.

@sqrrrl sqrrrl merged commit 4df1a2d into master Feb 26, 2019
@grant grant deleted the requirements.txt branch February 27, 2019 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants