Add a sample for listing groups with external access.#7
Merged
erickoledadevrel merged 7 commits intomasterfrom May 18, 2018
Merged
Add a sample for listing groups with external access.#7erickoledadevrel merged 7 commits intomasterfrom
erickoledadevrel merged 7 commits intomasterfrom
Conversation
grant
approved these changes
May 18, 2018
grant
suggested changes
May 18, 2018
admin_sdk/groups_settings/README.md
Outdated
|
|
||
| ## Detect External Access | ||
|
|
||
| This script lists all groups in your domain with some form of external acess |
Contributor
|
Lint if you want, but the lint errors for the whole repo will be handled later. pip install pylint
pylint admin_sdk/groups_settings/detect_external_access.py |
added 2 commits
May 18, 2018 14:21
Author
|
I've run the linter locally and it's clean on the new file. |
grant
approved these changes
May 18, 2018
Contributor
grant
left a comment
grant
left a comment
There was a problem hiding this comment.
Ran through a PEP8 checker, it detected some small nits.
LGTM o.w.
| who_can_post_message = settings['whoCanPostMessage'] | ||
| who_can_view_membership = settings['whoCanViewMembership'] | ||
| if (who_can_view_group == ANYONE_CAN_VIEW_GROUP | ||
| or who_can_join == ANYONE_CAN_JOIN_GROUP |
Contributor
There was a problem hiding this comment.
PEP8: line break before binary operator
In this case, the or should go after the cnf.
| ANYONE_CAN_VIEW_MEMBERSHIP = 'ANYONE_CAN_VIEW' | ||
|
|
||
| def get_credentials(): | ||
| """Gets valid user credentials from storage. |
Contributor
There was a problem hiding this comment.
""" should be on it's own line if we're being consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.