[WIP] Switch sheets/quickstart to from oauth2client to google-auth#60
Merged
erickoledadevrel merged 2 commits intogoogleworkspace:masterfrom Jan 16, 2019
Merged
Conversation
slokhorst
force-pushed
the
update-auth
branch
from
e641823 to
c9c2b7a
Compare
erickoledadevrel
suggested changes
Jan 11, 2019
erickoledadevrel
left a comment
erickoledadevrel
left a comment
There was a problem hiding this comment.
Thanks for doing the leg work here, and sorry for the long delay with the review. I've left a bunch of comments, let me know if anything is unclear. I'm also happy to pick up this work myself, now that you've come up with a working POC.
slokhorst
force-pushed
the
update-auth
branch
3 times, most recently
from
2f82e9a to
2f8298b
Compare
slokhorst
force-pushed
the
update-auth
branch
2 times, most recently
from
82c686f to
eafdba9
Compare
Contributor
Author
|
@erickoledadevrel thanks! I've made those changes and also converted all other quickstarts which use the same auth flow. |
slokhorst
force-pushed
the
update-auth
branch
from
eafdba9 to
f390f87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a start at tackling #10. Please review so I can convert all samples in one go.
Unfortunately, we are losing
oauth2client.file.Storage, so we have to manually (de)serialize and write/read the token file. The solution I have used here is to use pickle, but this adds another dependency, and a bunch of lines of boilerplate code. There might be a better solution.