Skip to content

Correcting error#50

Merged
erickoledadevrel merged 5 commits intogoogleworkspace:masterfrom
MattiaFailla:patch-1
Nov 30, 2018
Merged

Correcting error#50
erickoledadevrel merged 5 commits intogoogleworkspace:masterfrom
MattiaFailla:patch-1

Conversation

@MattiaFailla
Copy link
Copy Markdown
Contributor

Correcting error from user input.

Correcting error from user input.
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@MattiaFailla
Copy link
Copy Markdown
Contributor Author

MattiaFailla commented Nov 12, 2018 via email

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@erickoledadevrel
Copy link
Copy Markdown

The raw_input function isn't available in Python 3.6 (and the Travis build failed). Perhaps add a different codepath for Python 2 and 3?

@erickoledadevrel erickoledadevrel self-requested a review November 13, 2018 15:32
@erickoledadevrel erickoledadevrel self-assigned this Nov 13, 2018
@MattiaFailla
Copy link
Copy Markdown
Contributor Author

If it weren't possible to add two different codepath in order to explain the issue with Python2, it would be useful adding a comment with the correct version.

@grant
Copy link
Copy Markdown
Contributor

grant commented Nov 19, 2018

Any update to this PR?

@MattiaFailla
Copy link
Copy Markdown
Contributor Author

There haven't been any updates in the last 10 days. I suppose I have to change the code by adding the comment that explains the issue with Python 2.7 and then ask for a new pull request. Am I right?

@grant
Copy link
Copy Markdown
Contributor

grant commented Nov 29, 2018

@MattiaFailla
Copy link
Copy Markdown
Contributor Author

No, this PR tries to avoid users to encounter an input error while running the script with Python 2.x. I suggest to maintain the 3.x code and add a comment to let user know about the possible issue.

@erickoledadevrel
Copy link
Copy Markdown

@MattiaFailla - See above where it says "Add more commits by pushing to the patch-1 branch on MattiaFailla/python-samples." Commits added that way will be automatically included in this PR; you won't have to create a new one.

@MattiaFailla
Copy link
Copy Markdown
Contributor Author

Thank you for the clarification! I'll get to work and push changes.

@erickoledadevrel erickoledadevrel merged commit c261986 into googleworkspace:master Nov 30, 2018
@erickoledadevrel
Copy link
Copy Markdown

A simple solution, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants