Correcting error#50
Correcting error#50erickoledadevrel merged 5 commits intogoogleworkspace:masterfrom MattiaFailla:patch-1
Conversation
Correcting error from user input.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it!
On Nov 12, 2018 at 23:40, <googlebot<mailto:notifications@github.com>> wrote:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
…________________________________
What to do if you already signed the CLA
Individual signers
* It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
* Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot<http://go/cla#troubleshoot> (Public version<https://opensource.google.com/docs/cla/#troubleshoot>).
* The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>.
* The email used to register you as an authorized contributor must also be attached to your GitHub account<https://github.com/settings/emails>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#50 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALUoqXFcY-wrfjy3tqlSGcLCGw0PA4y4ks5uufjSgaJpZM4YakDf>.
|
|
CLAs look good, thanks! |
|
The |
|
If it weren't possible to add two different codepath in order to explain the issue with Python2, it would be useful adding a comment with the correct version. |
|
Any update to this PR? |
|
There haven't been any updates in the last 10 days. I suppose I have to change the code by adding the comment that explains the issue with Python 2.7 and then ask for a new pull request. Am I right? |
|
I don't think this PR fixes an issue with inputs. |
|
No, this PR tries to avoid users to encounter an input error while running the script with Python 2.x. I suggest to maintain the 3.x code and add a comment to let user know about the possible issue. |
|
@MattiaFailla - See above where it says "Add more commits by pushing to the patch-1 branch on MattiaFailla/python-samples." Commits added that way will be automatically included in this PR; you won't have to create a new one. |
|
Thank you for the clarification! I'll get to work and push changes. |
Checking python version to avoid input errors.
|
A simple solution, thanks! |
Correcting error from user input.