Consolidate redundant variables of quickstart.py#48
Consolidate redundant variables of quickstart.py#48erickoledadevrel merged 1 commit intogoogleworkspace:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed CLA. |
|
CLAs look good, thanks! |
|
Thanks for catching this! I think a better solution would be to just use that variable, and SAMPLE_SPREADSHEET_ID, directly: |
60696c1 to
410c2a9
Compare
|
Thanks for the review. Fixed the PR and rebased the branch. Besides, I included not only SAMPLE_RANGE_NAME but also SAMPLE_SPREADSHEET_ID. It is ready to review again now. |
|
pylint check does not pass. Fixing. |
410c2a9 to
9fde4a2
Compare
|
OK. Ready to review now! Thanks! |
SAMPLE_RANGE_NAME is not used at all in the current code. Use it to remove duplicate Class Data!A2:E.