Skip to content

Consolidate redundant variables of quickstart.py#48

Merged
erickoledadevrel merged 1 commit intogoogleworkspace:masterfrom
tai271828:pr-fix-typo
Nov 5, 2018
Merged

Consolidate redundant variables of quickstart.py#48
erickoledadevrel merged 1 commit intogoogleworkspace:masterfrom
tai271828:pr-fix-typo

Conversation

@tai271828
Copy link
Copy Markdown
Contributor

SAMPLE_RANGE_NAME is not used at all in the current code. Use it to remove duplicate Class Data!A2:E.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@tai271828
Copy link
Copy Markdown
Contributor Author

I signed CLA.

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@erickoledadevrel
Copy link
Copy Markdown

Thanks for catching this! I think a better solution would be to just use that variable, and SAMPLE_SPREADSHEET_ID, directly:

result = service.spreadsheets().values().get(spreadsheetId=SAMPLE_SPREADSHEET_ID,
                                             range=SAMPLE_RANGE_NAME).execute()

@tai271828 tai271828 changed the title Use SAMPLE_RANGE_NAME to remove duplicate Consolidate redundant variables of quickstart.py Nov 2, 2018
@tai271828
Copy link
Copy Markdown
Contributor Author

Thanks for the review. Fixed the PR and rebased the branch. Besides, I included not only SAMPLE_RANGE_NAME but also SAMPLE_SPREADSHEET_ID. It is ready to review again now.

@tai271828
Copy link
Copy Markdown
Contributor Author

pylint check does not pass. Fixing.

@tai271828
Copy link
Copy Markdown
Contributor Author

OK. Ready to review now! Thanks!

Copy link
Copy Markdown

@erickoledadevrel erickoledadevrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again!

@erickoledadevrel erickoledadevrel merged commit 840ba28 into googleworkspace:master Nov 5, 2018
@tai271828 tai271828 deleted the pr-fix-typo branch November 8, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants