Skip to content

Fix Drive Quickstart error on File names with unicode chars#37

Merged
asrivas merged 1 commit intomasterfrom
asrivas-patch-1
Oct 2, 2018
Merged

Fix Drive Quickstart error on File names with unicode chars#37
asrivas merged 1 commit intomasterfrom
asrivas-patch-1

Conversation

@asrivas
Copy link
Copy Markdown
Contributor

@asrivas asrivas commented Sep 9, 2018

If a file name has a unicode character such as "Édouard". The current print line will throw an error:
Traceback (most recent call last):
File "quickstart.py", line 50, in
main()
File "quickstart.py", line 47, in main
print('{0} ({1})'.format(item['name'], item['id']))

We simply need to change it to: print(u'{0} ({1})'.format(item['name'], item['id']))

If a file name has a unicode character such as "Édouard". The current print line will throw an error:
Traceback (most recent call last):
  File "quickstart.py", line 50, in <module>
    main()
  File "quickstart.py", line 47, in main
    print('{0} ({1})'.format(item['name'], item['id']))

We simply need to change it to: print(u'{0} ({1})'.format(item['name'], item['id']))
@grant
Copy link
Copy Markdown
Contributor

grant commented Sep 10, 2018

Looks good, but can we add this everywhere in the repo where we use .format?

@asrivas
Copy link
Copy Markdown
Contributor Author

asrivas commented Sep 11, 2018

#39

@grant
Copy link
Copy Markdown
Contributor

grant commented Sep 11, 2018

Why is there a 2nd PR? Can you use the same branch?

@asrivas
Copy link
Copy Markdown
Contributor Author

asrivas commented Sep 11, 2018

eh, didn't want to mess with rebasing and getting a new commit message for all the fixes since it contains unrelated files in the adminSDK

@asrivas asrivas closed this Sep 11, 2018
@asrivas asrivas reopened this Oct 2, 2018
@asrivas asrivas merged commit 6ebd2b6 into master Oct 2, 2018
@grant grant deleted the asrivas-patch-1 branch October 2, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants