Skip to content

Use a static port number#184

Closed
michaelbutler wants to merge 1 commit intogoogleworkspace:masterfrom
michaelbutler:master
Closed

Use a static port number#184
michaelbutler wants to merge 1 commit intogoogleworkspace:masterfrom
michaelbutler:master

Conversation

@michaelbutler
Copy link
Copy Markdown

After experiencing some confusion, and then seeing this issue, it seems that the PR to change the port from 8080 (the default) to 0 (which means it will be chosen randomly) did more harm than good.

Choosing 12997 due to google searches not turning up anything registered for that port. Or, we could just change it back to use 8080, which yes some people will have issues because it is a fairly common port for people playing around with Python and local docker services and what not. In any case something needs to change in the quickstart docs which do not seem to be in any public GitHub 😀

Cheers!

Choosing 12997 due to google searches not turning up anything registered for that port.
@google-cla
Copy link
Copy Markdown

google-cla bot commented Oct 26, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@michaelbutler
Copy link
Copy Markdown
Author

@googlebot I signed it!

@sqrrrl
Copy link
Copy Markdown
Member

sqrrrl commented Feb 11, 2021

Thanks, but given there were equally as many issues with using a fixed port number I'm going to decline this.

Ephemeral ports for localhost oauth callbacks are the preferred method. From the referenced issue, it looks like the root cause is people are misconfiguring the oauth credentials for the quickstart. That's something that can be addressed in the instructions for the quickstart, rather than re-introducing a bug.

@sqrrrl sqrrrl closed this Feb 11, 2021
@michaelbutler
Copy link
Copy Markdown
Author

Thanks. I'm all for a solution that updates the docs to provide a working solution. I currently don't understand how it could be possible to specify a callback URL in my Google Account that doesn't provide a port number, so I'm looking forward to seeing how such a thing works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants