Skip to content

refactor: add / use 'Client._delete_resource' method #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 6 commits into from
Jun 7, 2021
Merged

refactor: add / use 'Client._delete_resource' method #442

tseaver merged 6 commits into from
Jun 7, 2021

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented May 10, 2021 •
edited
Loading

Toward #38.

Note: this PR is based on afbf690 from PR #441. I will rebase to master when that PR lands. Done.

@tseaver tseaver requested review from a team, andrewsg and crwilcox May 10, 2021 18:27
@tseaver tseaver requested a review from a team as a code owner May 10, 2021 18:27
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label May 10, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2021
@tseaver tseaver marked this pull request as draft May 10, 2021 18:43
@tseaver tseaver force-pushed the 38-refactor-client-_delete_resource branch 3 times, most recently from 54c1d2d to 6244df0 Compare May 10, 2021 19:44
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2021
@tseaver tseaver mentioned this pull request May 11, 2021
Merged
@tseaver tseaver mentioned this pull request May 20, 2021
Closed
@tseaver tseaver force-pushed the 38-refactor-client-_delete_resource branch from 6244df0 to 7525c66 Compare June 7, 2021 19:27
@tseaver tseaver marked this pull request as ready for review June 7, 2021 19:27
chrisrossi
chrisrossi approved these changes Jun 7, 2021
View reviewed changes
Copy link

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2021
@tseaver tseaver merged commit 94fd0ca into master Jun 7, 2021
@tseaver tseaver deleted the 38-refactor-client-_delete_resource branch June 7, 2021 20:12
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
refactor: add / use 'Client._delete_resource' method (googleapis#442)
c5d2fcb 
Also, forward 'retry' through when deleting blobs during 'Bucket.delete'.

Toward googleapis#38.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
refactor: add / use 'Client._delete_resource' method (googleapis#442)
d5880e0 
Also, forward 'retry' through when deleting blobs during 'Bucket.delete'.

Toward googleapis#38.
@cojenco cojenco mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

@andrewsg andrewsg Awaiting requested review from andrewsg

1 more reviewer

@chrisrossi chrisrossi chrisrossi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver @chrisrossi @yoshi-kokoro