refactor: add / use 'Client._patch_resource' method #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
tseaver
force-pushed
the
38-refactor-client-_patch_resource
branch
2 times, most recently
from
4cdf0c4 to
5dd03f6
Compare
tseaver
force-pushed
the
38-refactor-client-_patch_resource
branch
from
5dd03f6 to
aa6d3a0
Compare
Also, add retry support to 'ACL.save', 'ACL.save_predefined', and 'ACL.clear'. Toward #38.
Indirectly, via 'ACL.save'. Note: this change also forwards the retry policy through to the 'ACL.save' call. Toward #38.
Indirectly, via 'ACL.save'. Note: this change also forwards the retry policy through to the 'ACL.save' call. Toward #38.
Indirectly, via 'ACL.save'. Note: this change also forwards the retry policy through to the 'ACL.save' call. Toward #38.
Indirecly, via 'ACL.save'. Also, adds 'timeout' and 'retry' support to 'Blob.make_public'. Toward #38.
Indirecly, via 'ACL.save'. Also, adds 'timeout' and 'retry' support to 'Blob.make_private'. Toward #38.
tseaver
force-pushed
the
38-refactor-client-_patch_resource
branch
from
efd5a14 to
9e030cb
Compare
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Add retry support to 'ACL.save', 'ACL.save_predefined', and 'ACL.clear'. Add 'timeout' and 'retry' support to 'Blob.make_private'. Toward googleapis#38.
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Add retry support to 'ACL.save', 'ACL.save_predefined', and 'ACL.clear'. Add 'timeout' and 'retry' support to 'Blob.make_private'. Toward googleapis#38.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add retry support to
ACL.save,ACL.save_predefined, andACL.clear.Toward #38.
Note: this PR is based on 44eeeb4 from PR #431. I will rebase to master when that PR lands.Done.