refactor: add / use 'Client._get_resource' method #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
tseaver
force-pushed
the
38-refactor-api-methods-_helpers
branch
2 times, most recently
from
aab3324 to
4f1110c
Compare
tseaver
force-pushed
the
38-refactor-api-methods-_helpers
branch
from
4bc1476 to
99e7e37
Compare
tseaver
force-pushed
the
38-refactor-api-methods-_helpers
branch
from
3942d75 to
2103462
Compare
tseaver
force-pushed
the
38-refactor-api-methods-_helpers
branch
from
2103462 to
794340a
Compare
tseaver
changed the title
tseaver
force-pushed
the
38-refactor-api-methods-_helpers
branch
from
794340a to
9bae346
Compare
Contributor
Author
|
Flaky systest reported in #435. Rerunning tests. |
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tseaver
force-pushed
the
38-refactor-api-methods-_helpers
branch
from
9bae346 to
44eeeb4
Compare
For use by API-invoking methods using the 'GET' method. Toward #38.
For parity with forthcoming '_put_resource', '_patch_resource', '_post_resource', and '_delete_resource' methods. Toward #38.
tseaver
force-pushed
the
38-refactor-api-methods-_helpers
branch
from
385f51d to
392343d
Compare
chrisrossi
reviewed
Jun 7, 2021
| method="GET", | ||
| path="%s/iam" % (self.path,), | ||
| info = client._get_resource( | ||
| "%s/iam" % (self.path,), |
There was a problem hiding this comment.
This is more of just a style thing, but in modern Python, should we be preferring str.format or f strings if Python 2 support has been dropped?
Contributor
Author
There was a problem hiding this comment.
Once we drop Python2, I would definitely prefer f-strings.
tseaver
added
automerge
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Use an explicit helper client method for `GET` requests, rather than manipulating client's private `_connection.api_request`. As a benefit, tests get *way* clearer. Toward googleapis#38 ~~Based on top of the branch from googleapis#430. I will rebase when that PR merges.~~
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Use an explicit helper client method for `GET` requests, rather than manipulating client's private `_connection.api_request`. As a benefit, tests get *way* clearer. Toward googleapis#38 ~~Based on top of the branch from googleapis#430. I will rebase when that PR merges.~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an explicit helper client method for
GETrequests, rather than manipulating client's private_connection.api_request. As a benefit, tests get way clearer.Toward #38
Based on top of the branch from #430. I will rebase when that PR merges.