Skip to content

tests: fix unit tests broken by dependency drift #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewsg merged 2 commits into from
May 5, 2021
Merged

tests: fix unit tests broken by dependency drift #430

andrewsg merged 2 commits into from
May 5, 2021

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented May 5, 2021 •
edited
Loading

Pin googleapis-common-protos FBO python2.7

Closes #429

Fix 'TestClient.test_ctor_wo_project', broken by googleapis/python-cloud-core#51

Closes #427

@tseaver tseaver requested review from a team, busunkim96, craiglabenz, crwilcox and frankyn May 5, 2021 16:40
@tseaver tseaver requested a review from a team as a code owner May 5, 2021 16:40
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label May 5, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2021
@tseaver tseaver mentioned this pull request May 5, 2021
Merged
@tseaver tseaver requested a review from andrewsg May 5, 2021 21:24
andrewsg
andrewsg approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewsg andrewsg merged commit 2e70a58 into master May 5, 2021
@andrewsg andrewsg deleted the 427-429-fix-test_client_wo_project-py27 branch May 5, 2021 21:34
tseaver added a commit that referenced this pull request May 6, 2021
@tseaver
tests: tweak systest deps install to avoid py27 conflict
cdfc246 
Follow on to PR #430.
@tseaver tseaver mentioned this pull request May 6, 2021
Merged
tseaver added a commit that referenced this pull request May 6, 2021
@tseaver
tests: tweak systest deps install to avoid py27 conflict
110870c 
Follow on to PR #430.
@tseaver tseaver mentioned this pull request May 6, 2021
Merged
andrewsg pushed a commit that referenced this pull request May 6, 2021
@tseaver
tests: tweak systest deps install to avoid py27 conflict (#433)
246a13b 
Follow on to PR #430.
gcf-merge-on-green bot pushed a commit that referenced this pull request May 20, 2021
@tseaver
chore: suppress renovate for googleapis-common-protos (#434)
34ce17e 
See #432, which undoes the work of #430.
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 7, 2021
@tseaver
refactor: add / use 'Client._get_resource' method (#431)
e0f1b71 
Use an explicit helper client method for `GET` requests, rather than manipulating client's private `_connection.api_request`.  As a benefit, tests get *way* clearer.

Toward #38

~~Based on top of the branch from #430.  I will rebase when that PR merges.~~
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
tests: fix unit tests broken by dependency drift (googleapis#430)
c5bf17b 
* tests: fix 'TestClient.test_ctor_wo_project'

Broken by googleapis/python-cloud-core#51

Closes googleapis#427

* chore(deps): pin googleapis-common-protos' FBO python2.7

Closes googleapis#429
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
tests: tweak systest deps install to avoid py27 conflict (googleapis#433
ced49b6 
)

Follow on to PR googleapis#430.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
chore: suppress renovate for googleapis-common-protos (googleapis#434)
b5f6df5 
See googleapis#432, which undoes the work of googleapis#430.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
refactor: add / use 'Client._get_resource' method (googleapis#431)
1c8dbeb 
Use an explicit helper client method for `GET` requests, rather than manipulating client's private `_connection.api_request`.  As a benefit, tests get *way* clearer.

Toward googleapis#38

~~Based on top of the branch from googleapis#430.  I will rebase when that PR merges.~~
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
tests: fix unit tests broken by dependency drift (googleapis#430)
c8b286e 
* tests: fix 'TestClient.test_ctor_wo_project'

Broken by googleapis/python-cloud-core#51

Closes googleapis#427

* chore(deps): pin googleapis-common-protos' FBO python2.7

Closes googleapis#429
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
tests: tweak systest deps install to avoid py27 conflict (googleapis#433
8ec69d2 
)

Follow on to PR googleapis#430.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
chore: suppress renovate for googleapis-common-protos (googleapis#434)
4b628d8 
See googleapis#432, which undoes the work of googleapis#430.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
refactor: add / use 'Client._get_resource' method (googleapis#431)
7972f9e 
Use an explicit helper client method for `GET` requests, rather than manipulating client's private `_connection.api_request`.  As a benefit, tests get *way* clearer.

Toward googleapis#38

~~Based on top of the branch from googleapis#430.  I will rebase when that PR merges.~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsg andrewsg andrewsg approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@craiglabenz craiglabenz Awaiting requested review from craiglabenz

@frankyn frankyn Awaiting requested review from frankyn

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests fail under python2.7 'TestClient.test_ctor_wo_project' fails with `google-cloud-core 1.6.0'

2 participants

@tseaver @andrewsg