Skip to content

Conversation

@chandra-siri
Copy link
Collaborator

@chandra-siri chandra-siri commented Dec 22, 2025

chore: optimization to reduce number of open TCP connections while running zonal system tests

  1. Increase ulimit -n 10000 before ssh'ing into the VM where system tests for zonal buckets are running.
  2. Delete mrd and writer instance and trigger gc.collect() ( this alone should suffice but increasing doing the above optimization to avoid future issues.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Dec 22, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chandra-siri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the robustness of system tests by addressing potential resource leaks. It introduces mechanisms for explicit garbage collection and object deletion at the conclusion of tests involving AsyncMultiRangeDownloader and AsyncAppendableObjectWriter instances. Furthermore, a new diagnostic tool has been integrated to monitor system resource usage, specifically open TCP connections, providing better visibility into test-related resource management.

Highlights

  • Explicit Resource Cleanup: Explicit calls to del for writer and mrd objects, followed by gc.collect(), have been added at the end of several system tests to ensure prompt garbage collection and resource release.
  • Resource Monitoring Utility: A new helper function, log_num_of_open_fd, has been introduced to monitor and log the number of open TCP connections, aiding in the diagnosis of potential resource leaks during test execution.
  • Test Refactoring: The write_one_appendable_object helper and appendable_object fixture have been commented out, and the object creation logic for test_mrd_open_with_read_handle has been moved directly into the test for more explicit control over object lifecycles.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request attempts to fix resource leaks in system tests by forcing garbage collection at the end of each test. While this may resolve the immediate issue, it's a workaround rather than a proper fix. My review focuses on addressing the root cause of the leak, which appears to be an unclosed gRPC client. I've suggested refactoring the tests to ensure deterministic resource cleanup. Additionally, the PR includes temporary debugging code and commented-out code that should be removed before merging to maintain code quality.

@chandra-siri chandra-siri changed the title force garbage collect mrd and writer at the end of every tests. chore: optimization to reduce number of open TCP connections while running zonal system tests Dec 22, 2025
@chandra-siri chandra-siri marked this pull request as ready for review December 22, 2025 11:03
@chandra-siri chandra-siri requested review from a team as code owners December 22, 2025 11:03
@chandra-siri chandra-siri merged commit fe6d7c9 into main Dec 22, 2025
17 checks passed
@chandra-siri chandra-siri deleted the debug_open_fd branch December 22, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants