-
Notifications
You must be signed in to change notification settings - Fork 167
chore: optimization to reduce number of open TCP connections while running zonal system tests #1691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @chandra-siri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the robustness of system tests by addressing potential resource leaks. It introduces mechanisms for explicit garbage collection and object deletion at the conclusion of tests involving Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request attempts to fix resource leaks in system tests by forcing garbage collection at the end of each test. While this may resolve the immediate issue, it's a workaround rather than a proper fix. My review focuses on addressing the root cause of the leak, which appears to be an unclosed gRPC client. I've suggested refactoring the tests to ensure deterministic resource cleanup. Additionally, the PR includes temporary debugging code and commented-out code that should be removed before merging to maintain code quality.
chore: optimization to reduce number of open TCP connections while running zonal system tests
ulimit -n 10000before ssh'ing into the VM where system tests for zonal buckets are running.mrdandwriterinstance and triggergc.collect()( this alone should suffice but increasing doing the above optimization to avoid future issues.