chore: run samples for all py versions #1673
Conversation
product-auto-label
bot
added
size: s
Summary of ChangesHello @chandra-siri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Python version testing matrix for samples. It broadens the testing coverage to include more recent Python versions (3.11, 3.12, 3.13) while explicitly excluding Python 3.8 from the test suite. The changes ensure that the sample tests run against a more up-to-date and relevant set of Python environments, improving the reliability of the samples across supported versions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Python versions for running sample tests, dropping support for Python 3.7 and 3.8, and enabling tests for all other specified versions. The changes look good, but there's a minor inconsistency in noxfile_config.py where Python 3.7 and 3.8 are still listed in ignored_versions even though they've been removed from the ALL_VERSIONS list in noxfile.py. While this doesn't cause an error, removing them would improve clarity and maintainability.
| # You can opt out from the test for specific Python versions. | ||
| 'ignored_versions': ["2.7", "3.6", "3.7", "3.11", "3.12", "3.13"], | ||
|
|
||
| "ignored_versions": ["2.7", "3.6", "3.7", "3.8"], |
There was a problem hiding this comment.
Python versions 3.7 and 3.8 have been removed from ALL_VERSIONS in noxfile.py. While it's not causing any harm, keeping them in ignored_versions here is redundant and could be confusing for future maintenance. It would be cleaner to remove them from this list as well.
| "ignored_versions": ["2.7", "3.6", "3.7", "3.8"], | |
| "ignored_versions": ["2.7", "3.6"], |
2 participants
chore: run samples for all py versions