Skip to content

feat: expose persisted size in mrd #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chandra-siri merged 5 commits into from
Dec 18, 2025
Merged

feat: expose persisted size in mrd #1671

chandra-siri merged 5 commits into from
Dec 18, 2025

Conversation

@chandra-siri
Copy link
Collaborator

@chandra-siri chandra-siri commented Dec 17, 2025

feat: expose persisted size in mrd

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Dec 17, 2025
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 17, 2025

Summary of Changes

Hello @chandra-siri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the asynchronous object reading and downloading capabilities by introducing and exposing the persisted_size attribute. This attribute provides the actual size of the object as stored in Google Cloud Storage, making this crucial metadata readily available to consumers of the AsyncMultiRangeDownloader and AsyncReadObjectStream classes. The size is retrieved directly from the object's metadata during the initial gRPC connection setup.

Highlights

  • New Feature: Persisted Size: Introduced a new persisted_size attribute in AsyncReadObjectStream to store the actual size of the object as it exists in Google Cloud Storage.
  • Data Population: The persisted_size attribute is now populated from the response.metadata.size field received during the initial gRPC response when the AsyncReadObjectStream is opened.
  • Attribute Exposure: The AsyncMultiRangeDownloader now exposes the persisted_size by copying it from its underlying AsyncReadObjectStream instance.
  • Unit Tests: Added comprehensive unit tests to both AsyncMultiRangeDownloader and AsyncReadObjectStream to ensure the correct capture, propagation, and exposure of the persisted_size.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 17, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request exposes the persisted_size from the underlying _AsyncReadObjectStream in the AsyncMultiRangeDownloader. The changes look good and correctly propagate the new attribute. I've added a couple of minor suggestions for improvement: one regarding attribute initialization for better code robustness and clarity, and another to correct a comment in the test files for precision.

@chandra-siri chandra-siri marked this pull request as ready for review December 17, 2025 14:15
@chandra-siri chandra-siri requested review from a team as code owners December 17, 2025 14:15
@chandra-siri
Copy link
Collaborator Author

chandra-siri commented Dec 18, 2025

Merging this PR despite failed checks because

  1. Samples - Python 3.14 was added newly & blocked by feat: add Python 3.14 to samples testing image GoogleCloudPlatform/python-docs-samples#13596

  2. python-sdk-zb-system-test-comment-based-trigger is duplicate of python-sdk-zb-system-test .( Config is changed now, will not be triggered in next PR.

@chandra-siri chandra-siri merged commit 0e2961b into main Dec 18, 2025
16 of 18 checks passed
@chandra-siri chandra-siri deleted the feat_expose_size branch December 18, 2025 03:58
@release-please release-please bot mentioned this pull request Dec 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suni72 suni72 suni72 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@suni72 suni72

Labels

api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chandra-siri @suni72