chore: skip failing samples due to public access prevention enforcement #1668
Conversation
This reverts commit b0a3349.
product-auto-label
bot
added
size: xs
Details in b/469643064
Summary of ChangesHello @chandra-siri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses failing sample tests related to public access functionality by temporarily skipping them. The failures are a result of a recent enforcement of public access prevention, and the tests will remain skipped until the underlying issue, tracked by bug Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
chandra-siri
force-pushed
the
chore_pap
branch
from
59139cd to
977086e
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request skips two tests related to public blob access that are failing due to an external issue. The change is reasonable, but I've suggested using pytest.mark.xfail instead of pytest.mark.skip. Using xfail will automatically flag when the tests start passing again, making it easier to track when the underlying bug is fixed and the tests can be fully re-enabled.
chandra-siri
changed the title
|
Samples - Python 3.14 is blocked until GoogleCloudPlatform/python-docs-samples#13596 |
3 participants
skip failing samples due to public access prevention enforcement.
More Details on b/469643064