Skip to content

feat: implement get_view_names() method #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 19 commits into from
Mar 20, 2023
Merged

feat: implement get_view_names() method #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
749f1ac
feat: implement get_view_names() method
IlyaFaer Feb 7, 2023
f51158a
fix import error for SQLAlchemy 1.4
IlyaFaer Feb 7, 2023
9a4efa9
avoid using SQLAlchemy 2.0 in the tests
IlyaFaer Feb 7, 2023
8c09a04
version fixes
IlyaFaer Feb 7, 2023
e559e92
use sqlalchemy <2.0 for snippets test
IlyaFaer Feb 8, 2023
fe0362f
use another data center
IlyaFaer Feb 24, 2023
4ffc21e
Update noxfile.py
asthamohta Mar 10, 2023
a8bf5cd
Merge branch 'main' into view_names
asthamohta Mar 20, 2023
7bdc918
Update noxfile.py
asthamohta Mar 20, 2023
13e16e3
Update noxfile.py
asthamohta Mar 20, 2023
de6ed5e
Update noxfile.py
asthamohta Mar 20, 2023
f494305
changes
asthamohta Mar 20, 2023
ad5a1f6
changes
asthamohta Mar 20, 2023
439e840
changes
asthamohta Mar 20, 2023
cc847dd
Update noxfile.py
asthamohta Mar 20, 2023
c24afe0
changes
asthamohta Mar 20, 2023
c98d13e
changes
asthamohta Mar 20, 2023
5fb9255
changes
asthamohta Mar 20, 2023
7f206c3
fixng query
asthamohta Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion create_test_database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def create_test_instance():
configs = list(CLIENT.list_instance_configs())
if not USE_EMULATOR:
# Filter out non "us" locations
configs = [config for config in configs if "us-south1" in config.name]
configs = [config for config in configs if "us-west1" in config.name]

instance_config = configs[0].name
create_time = str(int(time.time()))
Expand Down
18 changes: 18 additions & 0 deletions google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,24 @@ def create_connect_args(self, url):
{"user_agent": f"gl-{dist.project_name}/{dist.version}"},
)

@engine_to_connection
def get_view_names(self, connection, schema=None, **kw):
sql = """
SELECT table_name
FROM information_schema.views
WHERE TABLE_SCHEMA='{}'
""".format(
schema or ""
)

all_views = []
with connection.connection.database.snapshot() as snap:
rows = list(snap.execute_sql(sql))
for view in rows:
all_views.append(view[0])

return all_views

@engine_to_connection
def get_columns(self, connection, table_name, schema=None, **kw):
"""Get the table columns description.
Expand Down
7 changes: 4 additions & 3 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,18 +141,19 @@ def compliance_test_13(session):
)

session.install(
"pytest",
"pytest-cov",
"pytest-asyncio",
)

session.install("mock")
session.install("-e", ".[tracing]")
session.run("pip", "install", "sqlalchemy>=1.1.13,<=1.3.24", "--force-reinstall")
session.run("pip", "install", "pytest==6.2.2", "--force-reinstall")
session.run("pip", "install", "opentelemetry-api<=1.10", "--force-reinstall")
session.run("pip", "install", "opentelemetry-sdk<=1.10", "--force-reinstall")
session.run("python", "create_test_database.py")
session.run("pip", "install", "pytest==6.2.2", "--force-reinstall")
session.run(
"pip", "install", "pytest-asyncio<0.21.0", "--force-reinstall", "--no-deps"
)

session.run(
"py.test",
Expand Down