Skip to content

test: fix numeric compliance test #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larkee merged 20 commits into from
May 13, 2021
Merged

test: fix numeric compliance test #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
aea221e
test: fix numeric compliance test
HemangChothani Mar 16, 2021
68e5e50
fix: resolve conflict
HemangChothani Mar 16, 2021
30c670e
fix: resolve conflict and add tests
HemangChothani Mar 23, 2021
69bbf06
fix: skip tests
HemangChothani Mar 23, 2021
eb7b704
fix: remove override methods
HemangChothani Mar 24, 2021
e4ee817
Merge branch 'main' of https://github.com/cloudspannerecosystem/pytho…
HemangChothani Apr 1, 2021
b627406
test: resolve conflict
HemangChothani Apr 5, 2021
45bf24e
test: resolve conflict
HemangChothani Apr 8, 2021
e87f7e0
test: conflict resolved
HemangChothani Apr 15, 2021
664b897
test: enable advance test cases
HemangChothani Apr 26, 2021
7ab59eb
Merge branch 'main' of https://github.com/cloudspannerecosystem/pytho…
HemangChothani Apr 27, 2021
c04d8cf
Merge branch 'main' into numeric_compliance_test
larkee May 3, 2021
e28c568
test: add override reason
HemangChothani May 7, 2021
2037274
Merge branch 'numeric_compliance_test' of https://github.com/cloudspa…
HemangChothani May 7, 2021
cab7c69
test: close the property
HemangChothani May 10, 2021
be12b95
Merge branch 'main' of https://github.com/cloudspannerecosystem/pytho…
HemangChothani May 11, 2021
589fa92
test: resolve conflict
HemangChothani May 11, 2021
69e593b
test: resolve conflict
HemangChothani May 12, 2021
5295941
test: resolve conflict
HemangChothani May 12, 2021
ffd7499
Merge branch 'main' of https://github.com/cloudspannerecosystem/pytho…
HemangChothani May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions google/cloud/sqlalchemy_spanner/requirements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,9 @@ def get_isolation_levels(self, _):
dict: isolation levels description.
"""
return {"default": "SERIALIZABLE", "supported": ["SERIALIZABLE", "AUTOCOMMIT"]}

@property
def precision_numerics_enotation_large(self):
"""target backend supports Decimal() objects using E notation
to represent very large values."""
return exclusions.open()
7 changes: 4 additions & 3 deletions google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,9 +288,6 @@ def visit_large_binary(self, type_, **kw):
def visit_DECIMAL(self, type_, **kw):
return "NUMERIC"

def visit_NUMERIC(self, type_, **kw):
return "NUMERIC"

def visit_VARCHAR(self, type_, **kw):
return "STRING({})".format(type_.length or "MAX")

Expand All @@ -303,6 +300,9 @@ def visit_BOOLEAN(self, type_, **kw):
def visit_DATETIME(self, type_, **kw):
return "TIMESTAMP"

def visit_NUMERIC(self, type_, **kw):
return "NUMERIC"

def visit_BIGINT(self, type_, **kw):
return "INT64"

Expand All @@ -329,6 +329,7 @@ class SpannerDialect(DefaultDialect):
supports_sequences = True
supports_native_enum = True
supports_native_boolean = True
supports_native_decimal = True

ddl_compiler = SpannerDDLCompiler
preparer = SpannerIdentifierPreparer
Expand Down
Loading