Skip to content

Conversation

@asthamohta
Copy link
Contributor

@asthamohta asthamohta commented Sep 27, 2022

Adding requirements.in and .txt with hashes

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Sep 27, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Sep 27, 2022
@IlyaFaer
Copy link
Contributor

IlyaFaer commented Sep 29, 2022

@asthamohta, so, it looks like keyring package requires jeepney, and it's version is not particular.

ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not:
    jeepney>=0.4.2 from https://files.pythonhosted.org/packages/ae/72/2a1e2290f1ab1e06f71f3d0f1646c9e4634e70e1d37491535e19266e8dc9/jeepney-0.8.0-py3-none-any.whl#sha256=c0a454ad016ca575060802ee4d590dd912e35c122fa04e70306de3d076cce755 (from keyring==23.9.3->-r .kokoro/requirements.txt (line 280))

I suppose we can simply add the jeepney package into requirements to explicitly set its version.

@asthamohta asthamohta merged commit 61a13d4 into googleapis:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants