Skip to content

fix: Spanner auto managed indexes should not be introspected #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IlyaFaer merged 8 commits into from
Sep 2, 2022
Merged

fix: Spanner auto managed indexes should not be introspected #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e3c5c9c
fix: Spanner auto managed indexes should not be introspected
IlyaFaer Aug 31, 2022
ba94fee
order indexes during introspection
IlyaFaer Aug 31, 2022
22a96b8
use order in the indexes test
IlyaFaer Aug 31, 2022
1e34a53
fix
IlyaFaer Aug 31, 2022
52d1b9b
fix
IlyaFaer Aug 31, 2022
cbd8242
fix
IlyaFaer Aug 31, 2022
7837698
fix
IlyaFaer Aug 31, 2022
d9df575
fix
IlyaFaer Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,9 @@ def get_indexes(self, connection, table_name, schema=None, **kw):
WHERE
i.table_name="{table_name}"
AND i.index_type != 'PRIMARY_KEY'
AND i.spanner_is_managed = FALSE
Copy link
Contributor Author

@IlyaFaer IlyaFaer Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't show automatic indexes ruled by Spanner under the hood

GROUP BY i.index_name, i.is_unique
ORDER BY i.index_name
""".format(
table_name=table_name
)
Expand Down
7 changes: 7 additions & 0 deletions test/test_suite_13.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,6 +939,13 @@ def test_array_reflection(self):

tab.drop()

def _assert_insp_indexes(self, indexes, expected_indexes):
expected_indexes.sort(key=lambda item: item["name"])

index_names = [d["name"] for d in indexes]
exp_index_names = [d["name"] for d in expected_indexes]
assert sorted(index_names) == sorted(exp_index_names)
Copy link
Contributor Author

@IlyaFaer IlyaFaer Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overriding the test to check indexes in ordered fashion



class CompositeKeyReflectionTest(_CompositeKeyReflectionTest):
@testing.requires.foreign_key_constraint_reflection
Expand Down
7 changes: 7 additions & 0 deletions test/test_suite_14.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,13 @@ def test_get_temp_table_unique_constraints(self):
def test_get_temp_table_columns(self):
pass

def _assert_insp_indexes(self, indexes, expected_indexes):
expected_indexes.sort(key=lambda item: item["name"])

index_names = [d["name"] for d in indexes]
exp_index_names = [d["name"] for d in expected_indexes]
assert sorted(index_names) == sorted(exp_index_names)


class CompositeKeyReflectionTest(_CompositeKeyReflectionTest):
@testing.requires.foreign_key_constraint_reflection
Expand Down