fix: Spanner auto managed indexes should not be introspected #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaFaer
added
the
type: bug
product-auto-label
bot
added
the
api: spanner
IlyaFaer
commented
Aug 31, 2022
| WHERE | ||
| i.table_name="{table_name}" | ||
| AND i.index_type != 'PRIMARY_KEY' | ||
| AND i.spanner_is_managed = FALSE |
Contributor
Author
There was a problem hiding this comment.
Don't show automatic indexes ruled by Spanner under the hood
IlyaFaer
commented
Aug 31, 2022
|
|
||
| index_names = [d["name"] for d in indexes] | ||
| exp_index_names = [d["name"] for d in expected_indexes] | ||
| assert sorted(index_names) == sorted(exp_index_names) |
Contributor
Author
There was a problem hiding this comment.
Overriding the test to check indexes in ordered fashion
ansh0l
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #231
SQLAlchemy introspection method returns all the indexes, including those managed by Spanner internally. As any manipulations with indexes auto managed by Spanner can cause troubles, it's fair to prevent dialect from noticing these indexes. Fortunately,
information_schemaincludes a flag, which makes it easy.