Skip to content

chore: changing default region to us-west1#640

Merged
vi3k6i5 merged 9 commits intogoogleapis:mainfrom
asthamohta:change-region
Dec 21, 2021
Merged

chore: changing default region to us-west1#640
vi3k6i5 merged 9 commits intogoogleapis:mainfrom
asthamohta:change-region

Conversation

@asthamohta
Copy link
Copy Markdown
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Nov 11, 2021
@asthamohta asthamohta requested a review from larkee November 11, 2021 19:36
@asthamohta asthamohta marked this pull request as ready for review November 11, 2021 20:07
@asthamohta asthamohta requested a review from a team November 11, 2021 20:07
@asthamohta asthamohta requested a review from a team as a code owner November 11, 2021 20:07
@asthamohta asthamohta requested a review from vi3k6i5 November 11, 2021 20:08
@larkee larkee added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Nov 15, 2021
Copy link
Copy Markdown
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backup tests also use an additional instance with a different config:

if "-us-" in config.name and config.name != current_config:

We should probably prevent that one from choosing us-central1 for now as well.

We should also make this change for the samples:
https://github.com/googleapis/python-spanner/blob/main/samples/samples/conftest.py#L90

@asthamohta asthamohta requested a review from a team as a code owner November 16, 2021 05:06
@asthamohta asthamohta requested a review from nicain November 16, 2021 05:06
@asthamohta asthamohta force-pushed the change-region branch 2 times, most recently from 76fd990 to a518d2b Compare November 16, 2021 05:37
@asthamohta asthamohta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 8, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 8, 2021
@asthamohta asthamohta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 15, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 16, 2021
@asthamohta asthamohta added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Dec 20, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 20, 2021
Copy link
Copy Markdown
Contributor

@vi3k6i5 vi3k6i5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asthamohta asthamohta requested a review from larkee December 21, 2021 04:53
@vi3k6i5 vi3k6i5 merged commit 1f2c734 into googleapis:main Dec 21, 2021
vi3k6i5 pushed a commit to vi3k6i5/python-spanner that referenced this pull request Mar 29, 2022
* chore: changing default region to us-west1

* chore(deps): update all dependencies (googleapis#602)

* chore: add default_version and codeowner_team to .repo-metadata.json (googleapis#641)

* feat(db_api): support stale reads (googleapis#584)

* feat: removing changes from samples

* chore: change region

* fix: fix in sample list-backups

Co-authored-by: WhiteSource Renovate <bot@renovateapp.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Ilya Gurov <ilya.faer@mail.ru>
Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants