Skip to content

test: create instance before patching quickstart #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 2 commits into from
Jul 2, 2021
Merged

test: create instance before patching quickstart #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b31bd4a
test: create instance before patching quickstart
skuruppu Jul 2, 2021
20bd3c2
test: delete backups before deleting instance
skuruppu Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 44 additions & 5 deletions samples/samples/quickstart_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,26 +12,55 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import os
import time
import uuid

from google.cloud import spanner
import mock
import pytest

import quickstart
from snippets_test import cleanup_old_instances

SPANNER_INSTANCE = os.environ["SPANNER_INSTANCE"]

def unique_instance_id():
"""Creates a unique id for the database."""
return f"test-instance-{uuid.uuid4().hex[:10]}"


INSTANCE_ID = unique_instance_id()


def create_instance():
spanner_client = spanner.Client()
cleanup_old_instances(spanner_client)
instance_config = "{}/instanceConfigs/{}".format(
spanner_client.project_name, "regional-us-central1"
)
instance = spanner_client.instance(
INSTANCE_ID,
instance_config,
labels={"cloud_spanner_samples": "true", "created": str(int(time.time()))},
)
op = instance.create()
op.result(120) # block until completion


@pytest.fixture
def patch_instance():
original_instance = spanner.Client.instance

spanner_client = spanner.Client()
cleanup_old_instances(spanner_client)
create_instance()

def new_instance(self, unused_instance_name):
return original_instance(self, SPANNER_INSTANCE)
return original_instance(self, INSTANCE_ID)

instance_patch = mock.patch(
"google.cloud.spanner_v1.Client.instance", side_effect=new_instance, autospec=True
"google.cloud.spanner_v1.Client.instance",
side_effect=new_instance,
autospec=True,
)

with instance_patch:
Expand All @@ -41,7 +70,7 @@ def new_instance(self, unused_instance_name):
@pytest.fixture
def example_database():
spanner_client = spanner.Client()
instance = spanner_client.instance(SPANNER_INSTANCE)
instance = spanner_client.instance(INSTANCE_ID)
database = instance.database("my-database-id")

if not database.exists():
Expand All @@ -50,7 +79,17 @@ def example_database():
yield


def drop_instance():
spanner_client = spanner.Client()
instance = spanner_client.instance(INSTANCE_ID)
instance.delete()


def test_quickstart(capsys, patch_instance, example_database):
quickstart.run_quickstart()
out, _ = capsys.readouterr()

# Drop created instance before verifying output.
drop_instance()

assert "[1]" in out
6 changes: 6 additions & 0 deletions samples/samples/snippets_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import uuid

from google.cloud import spanner
from google.cloud.spanner_v1.instance import Backup
from google.cloud.spanner_v1.instance import Instance
import pytest

Expand Down Expand Up @@ -43,6 +44,11 @@ def cleanup_old_instances(spanner_client):
create_time = int(instance.labels["created"])
if create_time > cutoff:
continue

for backup_pb in instance.list_backups():
backup = Backup.from_pb(backup_pb, instance)
backup.delete()

instance.delete()


Expand Down