Skip to content

Conversation

@release-please
Copy link
Contributor

@release-please release-please bot commented Apr 23, 2020

🤖 I have created a release *beep* *boop*

1.5.0 (2020-05-04)

Features

  • add methods for listing snapshots (via synth) (#66) (4ce898e)
  • send client id with StreamingPullRequest (#58) (9f8acfa), closes #62

This PR was generated with Release Please.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 23, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 23, 2020
@pradn pradn requested review from plamut and pradn April 23, 2020 18:26
@pradn
Copy link
Contributor

pradn commented Apr 23, 2020

Unfortunately this commit isn't showing up here because I forgot to follow conventional commits for this change. It's a pretty minor comment change so it's okay.

a6b4c44

Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pradn The missing commit is OK, since it does not affect much. I am wary of releasing on Friday, though, thus if there is no rush, I would wait until Monday, and we can also sneak in the missing commit by then.

@plamut plamut added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 24, 2020
@plamut
Copy link
Contributor

plamut commented Apr 28, 2020

@pradn Do you plan to add that minor change, or just make the release as-is?

If the latter, feel free to just merge the PR.

Update: No releases this week, we need to wait then.

@release-please release-please bot closed this Apr 30, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 30, 2020
@release-please release-please bot reopened this Apr 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 30, 2020
@release-please release-please bot closed this May 4, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 4, 2020
@release-please release-please bot reopened this May 4, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 4, 2020
@plamut plamut removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 6, 2020
@plamut
Copy link
Contributor

plamut commented May 12, 2020

@pradn What's the status of this, releasing as-is or adding that previously-forgotten change, too?

@pradn
Copy link
Contributor

pradn commented May 12, 2020

I don't think it's worth the time to fix the minor issue. Gonna push the release button.

@pradn pradn merged commit ebf83ec into master May 12, 2020
@yoshi-automation
Copy link
Contributor

@pradn
Copy link
Contributor

pradn commented May 12, 2020

I updated the release notes:
https://github.com/googleapis/python-pubsub/releases/tag/v1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autorelease: published cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants