chore: use public post processor image #493
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: pubsub
google-cla
bot
added
the
cla: yes
plamut
reviewed
Sep 3, 2021
Contributor
plamut
left a comment
plamut
left a comment
There was a problem hiding this comment.
I ran the commands and they run without error. However, I didn't notice that the local changes I made to owlbot.py had any effect? For example, I modified one of the replacement rules, but the change was not reflected in the generated code.
Or did I misunderstand and the post-processor image does not use the local owlbot.py file? (and is there a way to tell it do so?)
Contributor
|
@parthea Bump. 🙃 |
Contributor
Author
|
Hi @plamut , You should see changes when you modify owlbot.py. Please make sure to run all 4 commands below in the root of your clone of this repo. |
Contributor
|
@parthea I confirm that running these commands makes local changes to one's repo fork. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with owlbot mentioned in #492 is fixed. I'd like to switch back to using the public post processor image.
This PR migrates from using a private post processor image
gcr.io/repo-automation-bots/owlbot-python:latestto a public onegcr.io/cloud-devrel-public-resources/owlbot-python:latestwhich is used by automation to update templated files across python repositories in the googleapis org.Use the following commands to test the feature:
The benefit is that external maintainers should now be able to run the post-processor locally and PRs should continue to be opened by automation when there are updates to templated files.
I tested the functionality in the python-datastream repository and it seems to be working correctly. If there is any issue , we can roll back to the private post processor image.