Skip to content

chore: remove obsolete replacements in owlbot.py #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 3 commits into from
Sep 2, 2021
Merged

chore: remove obsolete replacements in owlbot.py #492

gcf-merge-on-green merged 3 commits into from
Sep 2, 2021

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Sep 2, 2021 •
edited
Loading

This PR also switches the post processor image from gcr.io/cloud-devrel-public-resources/owlbot-python:latest to gcr.io/repo-automation-bots/owlbot-python:latest as there is a bug in owlbot where it only opens PRs when the post processor image is in the project repo-automation-bots. I've bumped the priority of the bug to p1 here: googleapis/repo-automation-bots#1790

@parthea parthea requested review from a team as code owners September 2, 2021 15:17
@parthea parthea requested a review from crwilcox September 2, 2021 15:17
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Sep 2, 2021
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 2, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 2, 2021
@parthea
Copy link
Contributor Author

parthea commented Sep 2, 2021

@plamut please could you review/approve? The changes in the PR also include the latest synthtool template changes. This repo was not upto date with synthtool templates due to the bug that I linked to above.

plamut
plamut approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 2, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 2, 2021
@parthea parthea added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 2, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 2, 2021
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 2, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8ae2b5a into main Sep 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the remove-obsolete-replacements-owlbot branch September 2, 2021 15:36
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 2, 2021
@parthea parthea mentioned this pull request Sep 3, 2021
Closed
@plamut plamut mentioned this pull request Sep 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@plamut plamut plamut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@plamut plamut

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parthea @plamut @yoshi-kokoro