Skip to content

test: add system tests for common RBAC operations #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
plamut merged 4 commits into from
Feb 21, 2020
Merged

test: add system tests for common RBAC operations #34

plamut merged 4 commits into from
Feb 21, 2020

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Feb 20, 2020 •
edited
Loading

Fixes #8.

This PR adds several system tests focusing on RBAC.

I used all non-admin PubSub roles in common happy use cases. If there are other uses cases that should also be added, feel free to suggest in the comments.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary) - discussed at a meeting, will be addressed separately

@plamut plamut added type: process A process-related concern. May include testing, release, or the like. testing labels Feb 20, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 20, 2020
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2020
@plamut
Copy link
Contributor Author

plamut commented Feb 20, 2020 •
edited
Loading

Hmm, the snapshot seek test seems to be flaky. Are snapshot not "instant" by any chance?

Update: Yes, creating a snapshot is actually an async operation on the server, despite a "success" is returned. In the short term we need to disable such flaky test. I will do that tomorrow.

@plamut plamut requested a review from pradn February 21, 2020 10:41
pradn
pradn reviewed Feb 21, 2020
View reviewed changes
pradn
pradn reviewed Feb 21, 2020
View reviewed changes
pradn
pradn reviewed Feb 21, 2020
View reviewed changes
pradn
pradn approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@pradn pradn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pradn
Copy link
Contributor

pradn commented Feb 21, 2020

Good to merge!

@plamut plamut merged commit a1855d1 into googleapis:master Feb 21, 2020
@plamut plamut deleted the iss-8 branch February 21, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pradn pradn pradn approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. testing type: process A process-related concern. May include testing, release, or the like.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PubSub: Add more system tests covering various RBAC-related scenarios

5 participants

@plamut @pradn @googlebot @busunkim96 @yoshi-kokoro