Skip to content

fix(sample): mark test flaky #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
engelke merged 1 commit into from
Mar 11, 2021
Merged

fix(sample): mark test flaky #322

engelke merged 1 commit into from
Mar 11, 2021

Conversation

@anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Mar 11, 2021

Fixes #321

@anguillanneuf anguillanneuf requested a review from a team as a code owner March 11, 2021 17:26
@anguillanneuf anguillanneuf requested review from engelke and removed request for a team March 11, 2021 17:26
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 11, 2021
@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Mar 11, 2021
@anguillanneuf anguillanneuf changed the title samples: mark test flaky fix(sample): mark test flaky Mar 11, 2021
engelke
engelke approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit 83c85bd into master Mar 11, 2021
@engelke engelke deleted the samples-flaky branch March 11, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@engelke engelke engelke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

samples.snippets.subscriber_test: test_update_dead_letter_policy failed

2 participants

@anguillanneuf @engelke