Skip to content

fix: get channel target for a gRPC request #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mukund-ananthu merged 5 commits into from
Jan 29, 2025
Merged

fix: get channel target for a gRPC request #1339

mukund-ananthu merged 5 commits into from
Jan 29, 2025

Conversation

@ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Jan 22, 2025 •
edited
Loading

Depends on #1348.

This is a workaround to resolve the issue for accessing the gRPC channel target: b/388826364

Refer to grpc/grpc#38519 for a more stable solution.

@ohmayr ohmayr requested review from a team as code owners January 22, 2025 23:05
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/python-pubsub API. size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 22, 2025
@ohmayr ohmayr force-pushed the fix-pubsub-target-issue branch from df9cb1e to 135038e Compare January 28, 2025 20:54
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Jan 28, 2025
@mukund-ananthu
Copy link
Contributor

mukund-ananthu commented Jan 28, 2025

@ohmayr Could you please fix the unit tests.

@ohmayr
Copy link
Contributor Author

ohmayr commented Jan 28, 2025

@ohmayr Could you please fix the unit tests.

As discussed offline, this PR is dependent on #1348 and the unit tests should resolve once we merge it and rebase this PR on top of main.

@ohmayr ohmayr force-pushed the fix-pubsub-target-issue branch from 591a7a9 to 576a948 Compare January 29, 2025 20:56
@mukund-ananthu mukund-ananthu merged commit 16ea766 into main Jan 29, 2025
26 checks passed
@mukund-ananthu mukund-ananthu deleted the fix-pubsub-target-issue branch January 29, 2025 21:53
@release-please release-please bot mentioned this pull request Jan 29, 2025
Merged
ohmayr added a commit that referenced this pull request Mar 5, 2025
@ohmayr
Revert "fix: get channel target for a gRPC request (#1339)"
a8128c7 
This reverts commit 16ea766.
@ohmayr ohmayr mentioned this pull request Mar 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

+1 more reviewer

@mukund-ananthu mukund-ananthu mukund-ananthu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mukund-ananthu mukund-ananthu

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ohmayr @mukund-ananthu @parthea