feat: detect monitored resources on all GCP environments #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: logging
google-cla
bot
added
the
cla: yes
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
daniel-sanche
changed the title
This was
linked to
issues
Mar 2, 2021
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
freelerobot
approved these changes
Mar 5, 2021
This was referenced Mar 5, 2021
|
When will the next release be? |
Contributor
Author
|
It should be today. Just merging in the last PRs and letting tests run! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds monitored resource detection to all current GCP platforms (GAE, GKE, GCE, GCF, Cloud Run). Previously, we only supported GAE and GKE
I accomplished this by creating a new
_monitored_resources.pyfile that builds canonical resources for each environment, and contains a function to detect the active environment. It should be pretty straight forward, and won't be a disruptive change for existing usersI added new environment tests to check the resource on each environment, and unit tests to test the new file
#183
#57
#7
#10
#201