Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

chore: Fix linter errors (use isinstance instead of type)#464

Merged
bw-yuhogg merged 1 commit into
googleapis:mainfrom
bw-yuhogg:fix-lint
Aug 1, 2023
Merged

chore: Fix linter errors (use isinstance instead of type)#464
bw-yuhogg merged 1 commit into
googleapis:mainfrom
bw-yuhogg:fix-lint

Conversation

@bw-yuhogg

@bw-yuhogg bw-yuhogg commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea Just a linter fix, not worth it
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed) N/A
  • Appropriate docs were updated (if necessary) N/A

@bw-yuhogg bw-yuhogg requested review from a team August 1, 2023 16:49
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: datastore Issues related to the googleapis/python-datastore API. labels Aug 1, 2023
chalmerlowe
chalmerlowe approved these changes Aug 1, 2023
View reviewed changes

@chalmerlowe chalmerlowe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 1, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 1, 2023
@bw-yuhogg bw-yuhogg enabled auto-merge (squash) August 1, 2023 17:50
@bw-yuhogg bw-yuhogg merged commit 8d33038 into googleapis:main Aug 1, 2023
@bw-yuhogg bw-yuhogg deleted the fix-lint branch August 1, 2023 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@parthea parthea parthea approved these changes
@chalmerlowe chalmerlowe chalmerlowe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datastore Issues related to the googleapis/python-datastore API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bw-yuhogg @parthea @chalmerlowe