feat: infer project from explicit service account creds #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crwilcox
approved these changes
Jan 14, 2021
Contributor
|
@busunkim96 wdyt? |
busunkim96
reviewed
Jan 14, 2021
tseaver
added a commit
to googleapis/python-storage
that referenced
this pull request
May 5, 2021
andrewsg
pushed a commit
to googleapis/python-storage
that referenced
this pull request
May 5, 2021
* tests: fix 'TestClient.test_ctor_wo_project' Broken by googleapis/python-cloud-core#51 Closes #427 * chore(deps): pin googleapis-common-protos' FBO python2.7 Closes #429
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* tests: fix 'TestClient.test_ctor_wo_project' Broken by googleapis/python-cloud-core#51 Closes googleapis#427 * chore(deps): pin googleapis-common-protos' FBO python2.7 Closes googleapis#429
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* tests: fix 'TestClient.test_ctor_wo_project' Broken by googleapis/python-cloud-core#51 Closes googleapis#427 * chore(deps): pin googleapis-common-protos' FBO python2.7 Closes googleapis#429
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #27
See: googleapis/python-storage#177
See: googleapis/python-datastore#74