fix: handle query_params tuples in JSONConnection.build_api_url #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docstring says both dictionary and list of tuples are allowed, following the signature of [urlencode](https://docs.python.org/3.8/library/urllib.parse.html#urllib.parse.urlencode). Discovered while investigating test regression in the `google-cloud-translate` library.
google-cla
bot
added
the
cla: yes
This was referenced Sep 23, 2020
Merged
busunkim96
approved these changes
Sep 24, 2020
plamut
approved these changes
Sep 24, 2020
Contributor
plamut
left a comment
plamut
left a comment
There was a problem hiding this comment.
LGTM. I have a minor refactoring suggestion, but nothing blocking.
Co-authored-by: Peter Lamut <plamut@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docstring says both dictionary and list of tuples are allowed, following the signature of urlencode. Discovered while investigating test regression in the
google-cloud-translatelibrary.CC @shollyman