[DRAFT] chore: benchmark tests #776
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
Contributor
Author
|
closed in favor of #840 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, blocked on #747
This PR adds simple benchmark tests. The main goal currently is for performance profiling, to detect bottlenecks during development. In the future, we can extend this system to get more objective performance metrics, and to
run cross-language benchmarks, to test functionality against existing clients.
Implementation
Benchmarks are implemented in
tests/benchmarks/benchmarks.py, which define client and server logic to test as part of the benchmark.tests/benchmarks/test_benchmarks.pyis a pytest file that will drive the benchmarks on both the v3 client and the v3 client, and report timing results.Running
python -m pytest test_benchmarks.py --profilewill include a profile trace for each failed benchmark, which can be read through the CLI or visualized in snakeviz to find bottlenecks in the code. We can use this to optimize our code.Initial Benchmark results:
The v3 update is faster in some benchmarks, but slower in others. A quick look at the profile shows some obvious optimizations that can be made that should change these numbers very quickly though