This repository was archived by the owner on Apr 1, 2026. It is now read-only.
chore: use GOOGLE_CLOUD_PROJECT and update reads/filters region tags#60
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
kolea2
reviewed
Jun 25, 2020
| # This should error out if not set. | ||
| ret['GOOGLE_CLOUD_PROJECT'] = os.environ[env_key] | ||
| ret['GCLOUD_PROJECT'] = os.environ[env_key] | ||
| ret['GOOGLE_CLOUD_PROJECT'] = os.environ[env_key] |
Contributor
There was a problem hiding this comment.
can we delete one of these lines?
Contributor
There was a problem hiding this comment.
(there's a few other examples of this in other files as well)
Contributor
Author
There was a problem hiding this comment.
Whoops, bad copy-pasta 😅 . Removed the duplicates
kolea2
approved these changes
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I left this in limbo for too long and new commits were added to python-docs-samples. These are the contents of GoogleCloudPlatform/python-docs-samples#4065 and GoogleCloudPlatform/python-docs-samples#4022
See https://github.com/GoogleCloudPlatform/python-docs-samples/commits/master/bigtable