Skip to content

Conversation

@gkevinzheng
Copy link
Contributor

The service YAML I used to autogenerate the new Admin API was missing a few methods that should be marked as public:

- google.bigtable.admin.v2.BigtableInstanceAdmin.CreateLogicalView
- google.bigtable.admin.v2.BigtableInstanceAdmin.CreateMaterializedView
- google.bigtable.admin.v2.BigtableInstanceAdmin.DeleteLogicalView
- google.bigtable.admin.v2.BigtableInstanceAdmin.DeleteMaterializedView
- google.bigtable.admin.v2.BigtableInstanceAdmin.GetLogicalView
- google.bigtable.admin.v2.BigtableInstanceAdmin.GetMaterializedView
- google.bigtable.admin.v2.BigtableInstanceAdmin.ListLogicalViews
- google.bigtable.admin.v2.BigtableInstanceAdmin.ListMaterializedViews
- google.bigtable.admin.v2.BigtableInstanceAdmin.UpdateLogicalView
- google.bigtable.admin.v2.BigtableInstanceAdmin.UpdateMaterializedView

These methods were added in the service YAML and the client library re-generated.

@gkevinzheng gkevinzheng requested review from a team as code owners April 23, 2025 21:03
@gkevinzheng gkevinzheng requested review from parthea and removed request for a team April 23, 2025 21:03
@gkevinzheng gkevinzheng removed the request for review from parthea April 23, 2025 21:03
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/python-bigtable API. labels Apr 23, 2025
@snippet-bot
Copy link

snippet-bot bot commented Apr 23, 2025

Here is the summary of changes.

You are about to add 20 region tags.
You are about to delete 20 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gkevinzheng gkevinzheng merged commit 8a6ff11 into autogen-feature-branch Apr 23, 2025
4 of 7 checks passed
@gkevinzheng gkevinzheng deleted the new-selective-gapic-layer-v2 branch April 23, 2025 21:04
gkevinzheng added a commit that referenced this pull request Aug 1, 2025
…ration (#1177)

* chore: Removed old admin_v2 GAPIC layer (#1111)

* feat!: Generated Selective GAPIC layer for Admin API (#1112)

* chore: Updated service YAML by making all methods in BigtableInstanceAdmin public (#1113)

* refactor: Refactored classic client to use new Admin API (#1114)

* refactor: Refactored classic client to use new Admin API

* added newline after gapic_version files

* fix: Made generate_consistency_token and check_consistency public (#1116)

methods

* feat: Consistency polling + restore table for sync client in admin (#1117)

* feat: Prototyped handwritten layer

* Added newlines

* linting

* Added docstrings for restore table and consistency token polling;
removed gc_rule

* docs: owlbot related changes (#1133)

* docs: owlbot related changes

* Addressed PR feedback + made changes to toc.yml for docs pipeline

* Fixed type hint

* linting + added validation for admin section

* linting + added noqas to owlbot lines

* tests: Tests for sync client + fixes + client library versioning (#1132)

* tests: Tests for sync client + fixes + client library versioning

* Removed raise exception

* linting + name changes in tests + added test for timeout

* linting

* Fixed tests on Python 3.7

* feat: Proto-plus modifications for enforcing strict oneofs (#1126)

* feat: Proto-plus modifications for enforcing strict oneofs

* Added template directory + changed unit tests to pytest

* Finished README

* linting

* Added source of truth comment

* feat: Reworked the wait_for_consistency call (#1144)

* feat: Reworked the wait_for_consistency call

* linting

* Update google/cloud/bigtable/admin_v2/overlay/services/bigtable_table_admin/client.py

Co-authored-by: Mattie Fu <mattiefu@google.com>

* Improved documentation

* linting again

* linting

---------

Co-authored-by: Mattie Fu <mattiefu@google.com>

* feat: Async consistency polling harness (#1142)

* feat: Async consistency polling harness

* Fixed AsyncMock issue in Python 3.7

* Reworked async_consistency and added async client to __init__.py

* linting

* addressed review feedback

* linting

* feat: Restore Table LRO rework + async restore table (#1148)

* chore(tests): system tests for autogen API (#1151)

* tests: system tests for autogen API

* Fixed async system tests

* addressed review feedback

* Fixed system test failure at the end of a test run

* Linting

* more linting

* chore: Moved Admin API from google.cloud.bigtable.admin_v2 back to google.cloud.bigtable_admin_v2 (#1153)

* chore: Removed autogenerated files from the feature branch (#1170)

* chore: Merged selective GAPIC autogenerated changes into feature branch (#1175)

* chore: Merged selective GAPIC owlbot changes into feature branch

* linting

* changed comment text

* Removed redundant items

* Fixed owlbot infinitely appending text

* Added comments + fixed indentation in Owlbot

* Added anonymous credentials to client tests

* Fixed project ID issue in system tests

* Fixed docstrings and skipped system tests on emulator.

---------

Co-authored-by: Mattie Fu <mattiefu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants