Skip to content

chore: addressed lint issue with __version__ #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 2 commits into from
Nov 30, 2022
Merged

chore: addressed lint issue with __version__ #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcf9ccc
chore: addressed lint issue with __version__
thejaredchapman Nov 30, 2022
fcd27b7
add license header
thejaredchapman Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sqlalchemy_bigquery/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
SQLAlchemy dialect for Google BigQuery
"""

from .version import __version__ # noqa
from .version import __version__

from .base import BigQueryDialect, dialect # noqa
from .base import BigQueryDialect, dialect
from ._types import (
ARRAY,
BIGNUMERIC,
Expand All @@ -44,6 +44,8 @@
)

__all__ = [
"__version__",
"dialect",
"ARRAY",
"BIGNUMERIC",
"BigQueryDialect",
Expand Down
29 changes: 29 additions & 0 deletions tests/unit/test_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Copyright (c) 2022 The sqlalchemy-bigquery Authors
#
# Permission is hereby granted, free of charge, to any person obtaining a copy of
# this software and associated documentation files (the "Software"), to deal in
# the Software without restriction, including without limitation the rights to
# use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
# the Software, and to permit persons to whom the Software is furnished to do so,
# subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in all
# copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
# FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
# COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
# IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
# CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

import sqlalchemy_bigquery
import sqlalchemy_bigquery.version


def test_sqlalchemy_bigquery_has_version():
assert isinstance(sqlalchemy_bigquery.__version__, str)


def test_version_module_has_version():
assert isinstance(sqlalchemy_bigquery.version.__version__, str)