Skip to content

chore: type errors in bigframes.ml tests #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 2 commits into from
May 20, 2024
Merged

chore: type errors in bigframes.ml tests #702

gcf-merge-on-green merged 2 commits into from
May 20, 2024

Conversation

@ashleyxuu
Copy link
Contributor

@ashleyxuu ashleyxuu commented May 17, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal #340890167, 340891711, 340876028🦕

@ashleyxuu ashleyxuu requested a review from tswast May 17, 2024 14:01
@ashleyxuu ashleyxuu requested review from a team as code owners May 17, 2024 14:01
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 17, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label May 17, 2024
@ashleyxuu ashleyxuu changed the title fix: type errors in bigframes.ml tests chore: type errors in bigframes.ml tests May 17, 2024
@ashleyxuu ashleyxuu added the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 66d6979 into main May 20, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the ashleyxu-remodel-type-error branch May 20, 2024 15:36
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

Assignees

@stevewalker-de stevewalker-de

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashleyxuu @tswast @stevewalker-de