Skip to content

fix: type error in test_cluster #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GarrettWu merged 1 commit into from
May 17, 2024
Merged

fix: type error in test_cluster #698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/system/large/ml/test_cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,10 @@ def test_cluster_configure_fit_score_predict(
reloaded_model = model.to_gbq(
f"{dataset_id}.temp_configured_cluster_model", replace=True
)
# TODO(b/340875247): fix type error
assert reloaded_model._bqml_model is not None
assert (
f"{dataset_id}.temp_configured_cluster_model"
in reloaded_model._bqml_model.model_name # type: ignore
in reloaded_model._bqml_model.model_name
)
assert reloaded_model.n_clusters == 3
assert reloaded_model.init == "RANDOM"
Expand Down Expand Up @@ -144,10 +144,10 @@ def test_cluster_configure_fit_load_params(penguins_df_default_index, dataset_id
reloaded_model = model.to_gbq(
f"{dataset_id}.temp_configured_cluster_model", replace=True
)
# TODO(b/340875247): fix type error
assert reloaded_model._bqml_model is not None
assert (
f"{dataset_id}.temp_configured_cluster_model"
in reloaded_model._bqml_model.model_name # type: ignore
in reloaded_model._bqml_model.model_name
)
assert reloaded_model.n_clusters == 4
assert reloaded_model.init == "RANDOM"
Expand Down