Skip to content

chore: type check with mypy --check-untyped-defs option #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 18 commits into from
May 15, 2024
Merged

chore: type check with mypy --check-untyped-defs option #693

tswast merged 18 commits into from
May 15, 2024

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented May 15, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 15, 2024
@tswast tswast mentioned this pull request May 15, 2024
Merged
4 tasks
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels May 15, 2024
@tswast tswast marked this pull request as ready for review May 15, 2024 18:09
@tswast tswast requested review from a team as code owners May 15, 2024 18:09
@tswast tswast requested a review from chelsea-lin May 15, 2024 18:09
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 15, 2024
chelsea-lin
chelsea-lin approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

bigframes/operations/_matplotlib/core.py Outdated
@property
def result(self):
return self.axes
# TODO(b/): fix type error
Copy link
Contributor

@chelsea-lin chelsea-lin May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: b/340896123

@tswast tswast enabled auto-merge (squash) May 15, 2024 21:08
@tswast tswast merged commit 9fee857 into main May 15, 2024
@tswast tswast deleted the mypy-check-untyped-defs branch May 15, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees

@milkshakeiii milkshakeiii

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast @chelsea-lin @milkshakeiii