Skip to content

Conversation

@shobsi
Copy link
Contributor

@shobsi shobsi commented May 9, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 337077316 🦕

@shobsi shobsi requested review from a team as code owners May 9, 2024 23:43
@shobsi shobsi requested a review from TrevorBergeron May 9, 2024 23:43
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 9, 2024
@shobsi shobsi closed this May 10, 2024
@shobsi
Copy link
Contributor Author

shobsi commented May 10, 2024

ran into some merge mess, created a fresh one instead #677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants